[FIX] Can't open attachments on Tablet #1857
Conversation
|
|
Badal1234
changed the title
Badal1234
changed the title
app/index.js
Outdated
| ); | ||
|
|
||
| if (isAndroid) { | ||
| if (isAndroid && !isTablet) { |
There was a problem hiding this comment.
Hey @Badal1234! It's not correct 😅.
If we're showing this component we have certain that is a tablet, then it'll always evaluates to true and never enter on this condition, we're needing this ScrollView because we have some modals that have inputs and the keyboard is opened, it was added by #1742 and we can't do this condition here because it'll broken this fix.
Maybe you can use pageSheet value to handle the ScrollView and only add the ScrollView when isAndroid && !pageSheet.
There was a problem hiding this comment.
Thanks @djorkaeffalexandre ,for your review and suggestion.
|
You are right @djorkaeffalexandre, this change does not affect the previous fix. |
djorkaeffalexandre
changed the title
|
Hey @Badal1234, I tested it here and works fine with the proposal, but can you try to fix the error about the navigation on tablet? |
|
Sorry, @djorkaeffalexandre I didn't get any such error. When we close the modal it navigates to |
|
@Badal1234 check the logs of the app. :) It's trying to access data from room when you open some attachment on RoomView, because are navigating to RoomActionsView before go to AttachmentView. :( |
|
I have resolved the navigation error.The error is at |
|
Due to some issue I have closed this PR. |
4 participants
@RocketChat/ReactNative
Closes #1825